[webkit-reviews] review granted: [Bug 46016] [chromium] There should be an API for showing an external popup that does not require creation of a WebWidget : [Attachment 70876] Added the bounds where the popup should be shown to WebExternalPopup::show()

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 46016: [chromium] There should be an API for showing an external popup that
does not require creation of a WebWidget
https://bugs.webkit.org/show_bug.cgi?id=46016

Attachment 70876: Added the bounds where the popup should be shown to
WebExternalPopup::show()
https://bugs.webkit.org/attachment.cgi?id=70876&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70876&action=review

> WebKit/chromium/src/ExternalPopupMenu.cpp:70
> +    IntPoint location = v->contentsToWindow(rect.location());

nit: there is also a version of contentsToWindow that takes an IntRect,
and a WebRect can be implicitly created from an IntRect.  in other words,
you can rewrite this as:

  m_webExternalPopupMenu->show(v->contentsToWindow(rect));