[webkit-reviews] review denied: [Bug 47940] webkit-patch doesn't get along with git rm : [Attachment 71249] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 47940: webkit-patch doesn't get along with git rm
https://bugs.webkit.org/show_bug.cgi?id=47940

Attachment 71249: Patch
https://bugs.webkit.org/attachment.cgi?id=71249&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71249&action=review

r- for lack of tests (and because I think this isn't a complete fix and may be
wrong.)

> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:656
> +	   status_command = ['git', 'diff', '-r', '--name-status', '-C', '-M',
"--no-ext-diff", "--full-index", "--", self.merge_base(git_commit)]

Um.  Are you sure that's the right place?  I don't think it is.  I think you'd
want it after the merge base?  And what about the case where we're generating a
patch?