[webkit-reviews] review granted: [Bug 47961] Get old-run-webkit-tests mostly working with Win32 Perl : [Attachment 71237] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 47961: Get old-run-webkit-tests mostly working with Win32 Perl
https://bugs.webkit.org/show_bug.cgi?id=47961

Attachment 71237: Patch
https://bugs.webkit.org/attachment.cgi?id=71237&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71237&action=review

r=me

> WebKitTools/Scripts/old-run-webkit-tests:417
> +    $dumpToolName .= ".exe";

Optional:  I think there is a Perl-ish way to get the executable extension via
built-in variable or via the Config module ($Config{_exe}).

> WebKitTools/Scripts/old-run-webkit-tests:1331
> +    unshift @{$args}, "perl", $execScript;

It would be a good idea to extract all of these "perl" strings into a global
variable.  It will make it easier to replace them or update them later.

> WebKitTools/Scripts/webkitdirs.pm:1082
> +    print $vcBuildPath, "\n";

Debug print statement?