[webkit-reviews] review denied: [Bug 40655] Database access in worker threads results in WebKit SPI notifications being posted from worker threads : [Attachment 71084] patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40655: Database access in worker threads results in WebKit SPI
notifications being posted from worker threads
https://bugs.webkit.org/show_bug.cgi?id=40655

Attachment 71084: patch
https://bugs.webkit.org/attachment.cgi?id=71084&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71084&action=review

> WebKit/mac/ChangeLog:5
> +	   Repost the DatabaseTracker notifications to the main thread, if
needed.

This would probably be best as a function level comment. (And leave this area
for the bug title.)

> WebKit/mac/ChangeLog:8
> +	   Removing WebDatabaseTrackerClient::~WebDatabaseTrackerClient(),

If that is true, then leave the destructor declaration and remove the
implementation. Otherwise, you'll get the default destructor implementation.

(btw, this will likely generate the link error you had before, so you'll likely
need an implementation, but then this ChangeLog can be updated to be more
accurate.)

Also this type of comment would be better at the function level.

> WebKit/mac/Storage/WebDatabaseTrackerClient.mm:51
> +class DidModifyOriginData {

Inherit from Noncopyable.

> WebKit/win/ChangeLog:8
> +	   Removing WebDatabaseManager::~WebDatabaseManager(), because

Same comments as before.