[webkit-reviews] review granted: [Bug 47034] gl-teximage.html fails on chromium webkit mac bot : [Attachment 71091] revised patch: responding to kbr's review

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 47034: gl-teximage.html fails on chromium webkit mac bot
https://bugs.webkit.org/show_bug.cgi?id=47034

Attachment 71091: revised patch: responding to kbr's review
https://bugs.webkit.org/attachment.cgi?id=71091&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71091&action=review

This looks better. I note that it looks like there was a preexisting bug in the
calls to computeIncrementParameters for the 16-bit-per-pixel formats. It would
be worth adding an assert in computeIncrementParameters of the form
"ASSERT(!(bytesPerPixel % elementSizeInBytes))".

> WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:76
> +    bool srcByteOrder16Big;

I don't think the compiler is going to be able to figure out that this is
always initialized before use. Please initialize it to false.