[webkit-reviews] review denied: [Bug 47909] Make patch release explicit and not a magic part of "retry" status : [Attachment 71177] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 47909: Make patch release explicit and not a magic part of "retry" status
https://bugs.webkit.org/show_bug.cgi?id=47909

Attachment 71177: Patch
https://bugs.webkit.org/attachment.cgi?id=71177&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71177&action=review

> WebKitTools/Scripts/webkitpy/common/net/statusserver.py:116
> +    def release_work_item(self, queue_name, patch):
> +	   _log.debug("Releasing work item %s from %s" % (patch.id(),
queue_name))
> +	   release_patch_url = "%s/release-patch/%s" % (self.url, queue_name)
> +	   self._browser.open(release_patch_url)
> +	   self._browser.select_form(name="release_patch")
> +	   self._browser["attachment_id"] = patch.id()
> +	   self._browser.submit()

We need a network transaction for writing to appengine

> WebKitTools/Scripts/webkitpy/tool/mocktool.py:551
> +    def release_work_item(self, queue_name, patch):
> +	   pass

Should we log so we can test that this happens?