[webkit-reviews] review denied: [Bug 44158] [soup] implement ResourceHandle::platformSetDefersLoading : [Attachment 71176] updated patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 44158: [soup] implement ResourceHandle::platformSetDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=44158

Attachment 71176: updated patch
https://bugs.webkit.org/attachment.cgi?id=71176&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71176&action=review

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:739
> +    // Only supported for http(s) transfers. Something similar would
> +    // probably be needed for data transfers done with GIO.

This comment is inaccurate now that data URLs are handled by soup, I think. :)

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:746
> +    else
> +	   soup_session_unpause_message(defaultSession(),
d->m_soupMessage.get());

I think this presents a problem. The time between the creation of m_soupRequest
and m_soupMessage is an asynchronous call. If setDefersLoading(...) was called
while that call was in progress, the message would not be paused properly.
Perhaps there should be a companion call to soup_session_pause_message if the
message is m_defersLoading is true in sendRequestCallback.