[webkit-reviews] review denied: [Bug 47339] Web Inspector: Implement property toggling in InspectorCSSAgent : [Attachment 71158] [PATCH] Implemented another approach suggested by pfeldman
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 19 06:55:07 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 47339: Web Inspector: Implement property toggling in InspectorCSSAgent
https://bugs.webkit.org/show_bug.cgi?id=47339
Attachment 71158: [PATCH] Implemented another approach suggested by pfeldman
https://bugs.webkit.org/attachment.cgi?id=71158&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71158&action=review
> WebCore/inspector/InspectorStyleSheet.h:78
> + const Vector<InspectorStyleProperty> m_liveProperties;
I still don't get the iterator thing. What is it actually used for? Wouldn't it
be simpler to have a class that would build front-end objects for merged
properties in the loop?
More information about the webkit-reviews
mailing list