[webkit-reviews] review denied: [Bug 47716] [Qt] WebKit2 history, QWKHistory : [Attachment 71146] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Juha Savolainen
<juha.savolainen at weego.fi>'s request for review:
Bug 47716: [Qt] WebKit2 history, QWKHistory
https://bugs.webkit.org/show_bug.cgi?id=47716

Attachment 71146: patch
https://bugs.webkit.org/attachment.cgi?id=71146&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71146&action=review

Almost there!

> WebKit2/UIProcess/API/qt/qwkhistory.h:45
> +    QWKHistory(QWKHistoryPrivate* historyPrivate);

Please leave this as QWKHistory(); Just make it a friend and you can set the d
pointer manually.

> WebKit2/UIProcess/API/qt/qwkpage.cpp:486
> +    return d->m_history;

in privates we do not add m_.

> WebKit2/UIProcess/API/qt/qwkpage_p.h:88
> +    QWKHistory* m_history;

make this QWKHistory* history;