[webkit-reviews] review denied: [Bug 47733] [GTK] Soup cache code still has some warnings : [Attachment 71148] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 19 03:28:31 PDT 2010
Xan Lopez <xan.lopez at gmail.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 47733: [GTK] Soup cache code still has some warnings
https://bugs.webkit.org/show_bug.cgi?id=47733
Attachment 71148: proposed patch
https://bugs.webkit.org/attachment.cgi?id=71148&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71148&action=review
> WebCore/platform/network/soup/cache/webkit/soup-cache.c:302
>
The original code would NOT revalidate if the 'must-revalidate' is not present.
Your patch changes that so that it WILL revalidate if the key is not there. I
don't think that's right?
More information about the webkit-reviews
mailing list