[webkit-reviews] review granted: [Bug 47892] Web Inspector: do not access ResourcePanel from resources directly. : [Attachment 71147] [PATCH] Proposed change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 19 03:01:55 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 47892: Web Inspector: do not access ResourcePanel from resources directly.
https://bugs.webkit.org/show_bug.cgi?id=47892

Attachment 71147: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=71147&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71147&action=review

Nice change.

> WebCore/inspector/front-end/ResourcesPanel.js:1078
> +		   return resourceView.__proto__ ===
WebInspector.SourceView.prototype;

Why not check for (resourceView instanceof WebInspector.SourceView) instead?

> WebCore/inspector/front-end/ResourcesPanel.js:1080
> +		   return resourceView.__proto__ ===
WebInspector.ImageView.prototype;

ditto

> WebCore/inspector/front-end/ResourcesPanel.js:1082
> +		   return resourceView.__proto__ ===
WebInspector.FontView.prototype;

ditto

> WebCore/inspector/front-end/ResourcesPanel.js:1084
> +		   return resourceView.__proto__ ===
WebInspector.ResourceView.prototype;

ditto


More information about the webkit-reviews mailing list