[webkit-reviews] review requested: [Bug 46973] Need to swap glyphs for vertical writing : [Attachment 71131] Made some more changes pointed by mitz

[bugzilla-daemon at webkit.org]

Takumi Takano <takano1 at asia.apple.com> has asked  for review:
Bug 46973: Need to swap glyphs for vertical writing
https://bugs.webkit.org/show_bug.cgi?id=46973

Attachment 71131: Made some more changes pointed by mitz
https://bugs.webkit.org/attachment.cgi?id=71131&action=review

------- Additional Comments from Takumi Takano <takano1 at asia.apple.com>
Added some more changes pointed by mitz.
One exception is for the comment below;
> > LayoutTests/fast/text/international/vertical-text-metrics-test.html:17
> > +	 if (window.layoutTestController)
> > +	     layoutTestController.dumpAsText();
> 
> It’s good to have this dumps-as-text test for the metrics. Can you also make
a pixel test for the glyph variants?

We cannot get correct pixel images at this time, because laying out the text
box for vertical writing mode (e.g., flowing text vertically and stacking text
boxes tb-rl) hasn't been finished yet...