[webkit-reviews] review requested: [Bug 47873] iOS: ASSERT in Cache::adjustSize running layout tests : [Attachment 71120] [PATCH] Proposed Change

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 47873: iOS: ASSERT in Cache::adjustSize running layout tests
https://bugs.webkit.org/show_bug.cgi?id=47873

Attachment 71120: [PATCH] Proposed Change
https://bugs.webkit.org/attachment.cgi?id=71120&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I'll be rebasing and re-running test to verify.

If desired I may be able to make a test for this:

  - Cache a resource
  - Loop and continually prune the cache enough that it would likely underflow
(m_deadSize is unsigned and underflowing triggers the ASSERT)
  - Have the test pass if there was no assertion.

Another approach might be to add a method to Cache to verify its integrity.
This might be worth doing, so let me know!