[webkit-reviews] review granted: [Bug 47869] Make it possible to submit patches to the EWS bots : [Attachment 71116] should apply now
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 18 19:24:32 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 47869: Make it possible to submit patches to the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47869
Attachment 71116: should apply now
https://bugs.webkit.org/attachment.cgi?id=71116&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71116&action=review
ok
> WebKitTools/QueueStatusServer/handlers/submittoews.py:43
> + if not queue.is_ews():
> + return False
Should this be an assert?
> WebKitTools/QueueStatusServer/model/queues.py:75
> + # FIXME: active_work_items is a bad name for this lock-table.
no -
More information about the webkit-reviews
mailing list