[webkit-reviews] review granted: [Bug 47866] Implement webkit-patch suggest-reviewers : [Attachment 71109] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 18 18:08:03 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 47866: Implement webkit-patch suggest-reviewers
https://bugs.webkit.org/show_bug.cgi?id=47866

Attachment 71109: Patch
https://bugs.webkit.org/attachment.cgi?id=71109&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71109&action=review

Looks good to me.

I'm glad you beat me to it.  Nicely done. :)

> WebKitTools/Scripts/webkitpy/common/checkout/api.py:118
> +    def suggested_reviewers(self, git_commit):

I guess I figured Checkout would have had a more generic API (like the
CommitInfos for the last N revisions), but OK.


More information about the webkit-reviews mailing list