[webkit-reviews] review denied: [Bug 47510] new-run-webkit-tests: clean up port option-parsing code : [Attachment 70944] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 47510: new-run-webkit-tests: clean up port option-parsing code
https://bugs.webkit.org/show_bug.cgi?id=47510

Attachment 70944: Patch
https://bugs.webkit.org/attachment.cgi?id=70944&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70944&action=review

In general looks good.	r- for the mock inclusion and the __dict__ access.  I'd
like to know about if all the get_option deploys are necessary or if the goal
was consistency, or which. :)

Thanks!

> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:50
> +from webkitpy.tool import mocktool

I would rather just copy MockOptions into this file (under a new name) than
introduce this dependency.

> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:464
> +	       return self._options.__dict__[name]

Don't you mean http://docs.python.org/library/functions.html#getattr ?

> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:468
> +	   self._options.__dict__.setdefault(name, default_value)

This is the same as doing if not hasattr(): setattr().	I don't think we want
to grab at __dict__.

> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:534
> -	   if self._options.use_apache:
> +	   if self.get_option('use_apache'):

If get_option is "deprecated" as soon as we add the Port option stuff you
mentioned above, then why change these?  Do we hit them in a unit test?