[webkit-reviews] review granted: [Bug 47847] Add Queue class and add minimal unittesting of QueueStatusServer code : [Attachment 71081] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 47847: Add Queue class and add minimal unittesting of QueueStatusServer
code
https://bugs.webkit.org/show_bug.cgi?id=47847

Attachment 71081: Patch
https://bugs.webkit.org/attachment.cgi?id=71081&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71081&action=review

404!

> WebKitTools/QueueStatusServer/model/queues.py:73
> +    def short_name(self):
> +	   # HACK: chromium-ews is incorrectly named.
> +	   short_name = self._name.replace("chromium-ews", "Cr-Linux-ews")
> +	   short_name = short_name.replace("-ews", "")
> +	   short_name = short_name.replace("-queue", "")
> +	   return self._caplitalize_after_dash(short_name.capitalize())

This is all ridiculous.