[webkit-reviews] review denied: [Bug 47805] [GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode : [Attachment 71011] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 18 14:14:59 PDT 2010


Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 47805: [GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib
unicode
https://bugs.webkit.org/show_bug.cgi?id=47805

Attachment 71011: Patch
https://bugs.webkit.org/attachment.cgi?id=71011&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Looks good, but please fix all the variable names (e.g. m_codecAliases_UTF_8
--> m_codecAliasesUTF8). Thanks.


More information about the webkit-reviews mailing list