[webkit-reviews] review denied: [Bug 47716] [Qt] WebKit2 history, QWKHistory : [Attachment 71013] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Juha Savolainen
<juha.savolainen at weego.fi>'s request for review:
Bug 47716: [Qt] WebKit2 history, QWKHistory
https://bugs.webkit.org/show_bug.cgi?id=47716

Attachment 71013: patch
https://bugs.webkit.org/attachment.cgi?id=71013&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71013&action=review

> WebKit2/UIProcess/API/qt/qwkhistory.cpp:39
> +QWKHistory::QWKHistory(WebKit::WebBackForwardList* list)

This is not BC compatible. Our public classes (even in private: section) cannot
refer to WebCore / WebKit internals

> WebKit2/UIProcess/API/qt/qwkhistory.h:49
> +    WebKit::WebBackForwardList* m_backForwardList;

This class should take a QWKHistoryPrivate* d pointer, and the
WebKit::WebBackForwardList* should be inside that private class.