[webkit-reviews] review denied: [Bug 45443] [GTK] Support for viewport meta tag : [Attachment 70527] Proposed Patch7

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Joone Hur <joone at kldp.org>'s
request for review:
Bug 45443: [GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Attachment 70527: Proposed Patch7
https://bugs.webkit.org/attachment.cgi?id=70527&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70527&action=review

Great patch! The API changes look fine to me and the documentation is awesome.
I have a few very small nits.

> WebKit/gtk/ChangeLog:10
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [GTK] Support for viewport meta tag
> +	   https://bugs.webkit.org/show_bug.cgi?id=45443
> +
> +	   This patch allows to get the viewport attributes to set the width
and initial scale of the viewport
> +	   used to display web content.
> +

I think this ChangeLog should be a bit bigger. This patch effectively adds
viewport support to the GTK+ port, so it should probably have at least one
sentence about what the viewport support does.

> WebKit/gtk/webkit/webkitviewportattributes.cpp:116
> + * Returns the width of the #WebKitViewportAttributes in pixels.
> + *
> + * Returns: the width of the #WebKitViewportAttributes in pixels

Does this really need to be repeated for all these methods?

> WebKit/gtk/webkit/webkitviewportattributes.cpp:124
> +    g_return_val_if_fail(WEBKIT_IS_VIEWPORT_ATTRIBUTES(viewportAttributes),
0);
> +
> +    return viewportAttributes->priv->width;

I'd say remove the extra line here and in the rest of the two-line methods.

> WebKit/gtk/webkit/webkitviewportattributes.cpp:268
> +// for internal use only

New comments should be complete sentences.

> WebKit/gtk/webkit/webkitwebview.cpp:4529
> +    g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
> +
> +    webView->priv->viewportAttributes =
adoptPlatformRef(webkit_viewport_attributes_new(desktopWidth, deviceWidth,
deviceHeight, deviceDPI));

I'd say remove the extra line from the two line methods again.