[webkit-reviews] review granted: [Bug 46224] Reproducible Crash when Inspector Open in CSSStyleSelector::loadPendingImages() : [Attachment 71021] [PATCH] Same with the comment typo fixed.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 46224: Reproducible Crash when Inspector Open in
CSSStyleSelector::loadPendingImages()
https://bugs.webkit.org/show_bug.cgi?id=46224

Attachment 71021: [PATCH] Same with the comment typo fixed.
https://bugs.webkit.org/attachment.cgi?id=71021&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71021&action=review

Thanks for taking care of this!

> WebCore/ChangeLog:8
> +	   Web Inspector: [crash] when Inspector Open in
CSSStyleSelector::loadPendingImages().
> +	   https://bugs.webkit.org/show_bug.cgi?id=46224
> +
> +	   * CMakeLists.txt:

There should be a summary here of what the problem was, and what changes you
made to fix it.

Specifically I'd like to see mentioned that fact that calling through
doDispatchMessageOnFrontendPage() makes this asynchronous, by virtue of the
timer in Inspector.js. That is not at all apparent from these changes.

> WebKit/cf/ChangeLog:8
> +	   Web Inspector: [crash] when Inspector Open in
CSSStyleSelector::loadPendingImages().
> +	   https://bugs.webkit.org/show_bug.cgi?id=46224
> +
> +	   * WebCoreSupport/WebInspectorClientCF.cpp:

Again, these changelogs need some explanatory comments.