[webkit-reviews] review granted: [Bug 47772] Web Inspector: brush up URL parsing on the front-end. : [Attachment 70959] [PATCH] Same with layout tests not using old regex.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 47772: Web Inspector: brush up URL parsing on the front-end.
https://bugs.webkit.org/show_bug.cgi?id=47772

Attachment 70959: [PATCH] Same with layout tests not using old regex.
https://bugs.webkit.org/attachment.cgi?id=70959&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70959&action=review

> WebCore/inspector/front-end/utilities.js:396
> +String.prototype.asParsedURL = function()

I'd rather make it a function, not a method.

> WebCore/inspector/front-end/utilities.js:413
> +    return result;

You may want to cache result on the String object.