[webkit-reviews] review denied: [Bug 47623] Add AudioResampler files : [Attachment 70665] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Chris Rogers
<crogers at google.com>'s request for review:
Bug 47623: Add AudioResampler files
https://bugs.webkit.org/show_bug.cgi?id=47623

Attachment 70665: Patch
https://bugs.webkit.org/attachment.cgi?id=70665&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70665&action=review

> WebCore/platform/audio/AudioResampler.cpp:105
> +    for (unsigned i = 0; i < m_kernels.size(); ++i) {

dont' call a method within a loop. initialize the length outside the loop

> WebCore/platform/audio/AudioResampler.cpp:121
> +    for (unsigned i = 0; i < m_kernels.size(); ++i)

same here as above

> WebCore/platform/audio/AudioResampler.h:41
> +    AudioResampler(); // default to mono

This comment seems like it should be in the class description above, not
inline.

> WebCore/platform/audio/AudioResampler.h:53
> +    // 0 < rate <= MaxRate

seems like MaxRate should be in the header so that clients could use the max
rate if they so desired.

> WebCore/platform/audio/AudioResampler.h:59
> +protected:

should probably be private