[webkit-reviews] review denied: [Bug 29363] [HTML5][Forms] Support for <output> element : [Attachment 70950] A trial patch V0

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 29363: [HTML5][Forms] Support for <output> element
https://bugs.webkit.org/show_bug.cgi?id=29363

Attachment 70950: A trial patch V0
https://bugs.webkit.org/attachment.cgi?id=70950&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70950&action=review

Thank you for working on this.

The patch is too large to review.  I recommend to split this into
 - DOMSettableTokenList implementation and JSC binding,
 - V8 binding for DOMSettableTokenList,
 - "form" attribute support for form control elements, and
 - <output> element support.

> WebCore/WebCore.xcodeproj/project.pbxproj:14519
> +				4AD7D6631267D56B0020D6E8 /*
HTMLOutputElement.cpp */,

You should run WebKitTools/Scripts/sort-Xcode-project-file when you add files
to an Xcode project.