[webkit-reviews] review denied: [Bug 39625] [Qt] Sending a QInputMethodEvent::Selection event forces the Editor to go into Composition mode : [Attachment 70964] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 39625: [Qt] Sending a QInputMethodEvent::Selection event forces the Editor
to go into Composition mode
https://bugs.webkit.org/show_bug.cgi?id=39625

Attachment 70964: Patch
https://bugs.webkit.org/attachment.cgi?id=70964&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70964&action=review

> WebKit/qt/Api/qwebpage.cpp:1059
> +#if QT_VERSION >= 0x040600

Not necessary as we don't support Qt versions older than 4.6 on WebKit trunk.

> WebKit/qt/ChangeLog:8
> +	   Improve QWebPage handling of input method events.

Please elaborate.

> WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:-1522
> -    //Cancel current composition first
> -    inputAttributes <<
QInputMethodEvent::Attribute(QInputMethodEvent::Selection, 0, 0, QVariant());
> -    QInputMethodEvent eventSelection2("",inputAttributes);
> -    page->event(&eventSelection2);

Why are you removing this? I'm not saying it's wrong, it's just not stated
anywhere why it's being removed.