[webkit-reviews] review requested: [Bug 42248] [Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine) : [Attachment 70969] Fix GraphicsContextQt::drawLine with X11 paint engine (fifth edition, wuth moved #if)

[bugzilla-daemon at webkit.org]

Sergey A. Sukiyazov <sergey.sukiyazov at gmail.com> has asked  for review:
Bug 42248: [Qt] Hovering the mouse over links produce a trail of underlined
links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248

Attachment 70969:  Fix GraphicsContextQt::drawLine with X11 paint engine (fifth
edition, wuth moved #if)
https://bugs.webkit.org/attachment.cgi?id=70969&action=review

------- Additional Comments from Sergey A. Sukiyazov
<sergey.sukiyazov at gmail.com>
> You should leave "Reviewed by NOBODY (OOPS!)" and the commitbot should fill
it for you properly.
> 
> "Unreviewed" is essentially for build fixes.

Return back "Reviewed by NOBODY (OOPS!)". I've removed "Reviewed by NOBODY
(OOPS!)" after I get following message.

(In reply to comment #55)
> (From update of attachment 70404 [details])
> Rejecting patch 70404 from commit-queue.
> 
> Failed to run "['./WebKitTools/Scripts/webkit-patch',
'--status-host=queues.webkit.org', 'land-attachment', '--force-clean',
'--ignore-builders', '--quiet', '--non-interactive',
'--parent-command=commit-queue', 70404]" exit_code: 2
> Last 500 characters of output:
> /svn.webkit.org/repository/webkit/trunk ...
>     M    WebCore/ChangeLog
>     M    WebCore/platform/graphics/qt/GraphicsContextQt.cpp
> A repository hook failed: Commit blocked by pre-commit hook (exit code 1)
with output:
> svnlook: Can't write to stream: Broken pipe
> 
>     The following ChangeLog files contain OOPS:
> 
>	  trunk/WebCore/ChangeLog
> 
>     Please don't ever say "OOPS" in a ChangeLog file.
>  at /usr/local/git/libexec/git-core/git-svn line 572
> 
> 
> Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
> 
> Full output: http://queues.webkit.org/results/4339014