[webkit-reviews] review granted: [Bug 47735] Remove some functions from class Node and make a few others non-virtual : [Attachment 70919] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 47735: Remove some functions from class Node and make a few others
non-virtual
https://bugs.webkit.org/show_bug.cgi?id=47735

Attachment 70919: Patch
https://bugs.webkit.org/attachment.cgi?id=70919&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70919&action=review

r=me

> WebCore/ChangeLog:62
> +	   (WebCore::enclosingInline): Moved function here from the Node class.
Also
> +	   fixed an incorrect cast this function did, which assumed the
function
> +	   result was always an element, which the function does not guarantee.


Does this change observable behavior?

> WebCore/dom/Node.h:370
> +    // see @ref traversePreviousNode()

Is there a reason to keep a part of this comment in Javadoc style?