[webkit-reviews] review requested: [Bug 42248] [Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine) : [Attachment 70947] Fix GraphicsContextQt::drawLine with X11 paint engine (fifth edition, wuth moved #if)

[bugzilla-daemon at webkit.org]

Sergey A. Sukiyazov <sergey.sukiyazov at gmail.com> has asked  for review:
Bug 42248: [Qt] Hovering the mouse over links produce a trail of underlined
links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248

Attachment 70947:  Fix GraphicsContextQt::drawLine with X11 paint engine (fifth
edition, wuth moved #if)
https://bugs.webkit.org/attachment.cgi?id=70947&action=review

------- Additional Comments from Sergey A. Sukiyazov
<sergey.sukiyazov at gmail.com>
(In reply to comment #58)
> (From update of attachment 70421 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=70421&action=review
> 
> Some nitpicking. Do not forget got put the flags to "?" when you add a patch,
otherwise we don't see it is needing a review.
> 
> > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:57
> > +#include <QtCore>
QtCore no more needed. Removed.

> 
> Please include qglobal instead. Including QtCore means including all the
headers.
> 
> > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:845
> > +#if defined(Q_WS_X11) && defined(Q_OS_UNIX)
> 
Done.