[webkit-reviews] review canceled: [Bug 46775] getBoundingClientRect does not work with SVG <text> : [Attachment 70263] Fix and layout test

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at chromium.org> has canceled Cosmin Truta
<ctruta at chromium.org>'s request for review:
Bug 46775: getBoundingClientRect does not work with SVG <text>
https://bugs.webkit.org/show_bug.cgi?id=46775

Attachment 70263: Fix and layout test
https://bugs.webkit.org/attachment.cgi?id=70263&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
Same patch as before, but with the extra ASSERT removed from
Element::getBoundingClientRect.

The ASSERT is not necessary, since the following statement will crash
unambiguously if renderer() is null. In fact, that particular ASSERT might
generate confusion, because one must look carefully to see that it's *not* a
precondition.

(Eiffel's "require" and "ensure" clauses come to mind as a neat manner to
separate pre- and postconditions from the rest of the assertions. This is
useful both for compilation and documentation purposes.)