[webkit-reviews] review granted: [Bug 47749] serializeNodesWithNamespaces should be in MarkupAccumulator : [Attachment 70930] fixed per Adam's & Tony's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 15 17:49:21 PDT 2010


Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 47749: serializeNodesWithNamespaces should be in MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47749

Attachment 70930: fixed per Adam's & Tony's comments
https://bugs.webkit.org/attachment.cgi?id=70930&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70930&action=review

FWIW, you can call protected static methods on a parent class.

Adam asked the following:
> WebCore/editing/MarkupAccumulator.h:78
> +	   out.reserveInitialCapacity(length());
> +	   concatenateMarkups(out);
> +	   return String::adopt(out);

Why not String::createUninitialized?

> WebCore/ChangeLog:22
> +	   (WebCore::MarkupAccumulator::length): Added; calls
sumOfStringLengths.

Nit: calls totalLength

> WebCore/ChangeLog:26
> +	   (WebCore::StyledMarkupAccumulator::takeResults): Calls length,
sumOfStringLengths, and concatenateMarkups.

Nit: totalLength, and concatenateMarkup


More information about the webkit-reviews mailing list