[webkit-reviews] review granted: [Bug 47593] Require a user gesture to open the file dialog : [Attachment 70727] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 15 17:38:53 PDT 2010


Adam Barth <abarth at webkit.org> has granted Johnny Ding <jnd at chromium.org>'s
request for review:
Bug 47593: Require a user gesture to open the file dialog
https://bugs.webkit.org/show_bug.cgi?id=47593

Attachment 70727: patch v1
https://bugs.webkit.org/attachment.cgi?id=70727&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70727&action=review

> WebCore/rendering/RenderFileUploadControl.cpp:128
> +    if (!(frame() && frame()->loader()->isProcessingUserGesture()))

We usually say !frame() || !frame() ...


More information about the webkit-reviews mailing list