[webkit-reviews] review granted: [Bug 47756] Make a nullptr that works with OwnPtr and RefPtr : [Attachment 70924] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 15 17:07:38 PDT 2010


Geoffrey Garen <ggaren at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 47756: Make a nullptr that works with OwnPtr and RefPtr
https://bugs.webkit.org/show_bug.cgi?id=47756

Attachment 70924: Patch
https://bugs.webkit.org/attachment.cgi?id=70924&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70924&action=review

> JavaScriptCore/wtf/NullPtr.h:34
> +class nullptr_t { };

Would it be better to #ifndef nullptr_t here, to avoid overriding something if
it is provided by the compiler?

r=me


More information about the webkit-reviews mailing list