[webkit-reviews] review denied: [Bug 45748] Collect the beginning characters in a RegExp pattern for look-up optimization : [Attachment 69616] proposed patch v5

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Peter Varga
<pvarga at inf.u-szeged.hu>'s request for review:
Bug 45748: Collect the beginning characters in a RegExp pattern for look-up
optimization
https://bugs.webkit.org/show_bug.cgi?id=45748

Attachment 69616: proposed patch v5
https://bugs.webkit.org/attachment.cgi?id=69616&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think Michael raised enough significant issues here for an r-.

>I think the types for value and mask in BeginChar() should be signed 32 bit
values (maybe uint32_t) to ensure that two UChars fit.

Typo: "should be *unsigned*..."