[webkit-reviews] review granted: [Bug 47736] WebCore cache gets corrupted if revalidation request starts at a wrong time : [Attachment 70892] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 47736: WebCore cache gets corrupted if revalidation request starts at a
wrong time
https://bugs.webkit.org/show_bug.cgi?id=47736

Attachment 70892: proposed fix
https://bugs.webkit.org/attachment.cgi?id=70892&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70892&action=review

I am finding this a little hard to review because of the logging. Can we land
an initial patch that just adds the logging, and then land the bug fix
separately?

> WebCore/ChangeLog:6
> +	   <rdar://problem/8429396> WebCore cache gets corrupted if
revalidation request starts at a wrong time

I would call this “an inopportune time” maybe. It’s not “wrong”, is it?

> WebCore/loader/loader.cpp:387
> +	       if (resource->resourceToRevalidate())
> +		   cache()->revalidationFailed(resource);

Is this the bug fix?