[webkit-reviews] review granted: [Bug 47699] Crash in WebCore::ApplyStyleCommand::applyBlockStyle : [Attachment 70834] fixes the crash

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 47699: Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699

Attachment 70834: fixes the crash
https://bugs.webkit.org/attachment.cgi?id=70834&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70834&action=review

> WebCore/editing/ApplyStyleCommand.cpp:648
> +    if (visibleStart.isNull() || visibleStart.isOrphan() ||
visibleEnd.isNull() || visibleEnd.isOrphan())
> +	   return;

Makes me wish isOrphan returned true for null. There seem to be very few cases
where we check isOrphan and want to handle isNull differently.