[webkit-reviews] review denied: [Bug 46186] [Qt] window.close() doesn't work in qt : [Attachment 70868] patch3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 15 08:39:33 PDT 2010


Andreas Kling <kling at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request
for review:
Bug 46186: [Qt] window.close() doesn't work in qt
https://bugs.webkit.org/show_bug.cgi?id=46186

Attachment 70868: patch3
https://bugs.webkit.org/attachment.cgi?id=70868&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70868&action=review

> WebKit/qt/Api/qwebsettings.h:58
> +	   JavascriptCanCloseWindows,

This will break binary compatibility. Add it after the existing enum values
instead.


More information about the webkit-reviews mailing list