[webkit-reviews] review denied: [Bug 47716] [Qt] WebKit2 history, QWKHistory : [Attachment 70853] Initial implementation of QWKHistory.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Juha Savolainen
<juha.savolainen at weego.fi>'s request for review:
Bug 47716: [Qt] WebKit2 history, QWKHistory
https://bugs.webkit.org/show_bug.cgi?id=47716

Attachment 70853: Initial implementation of QWKHistory.
https://bugs.webkit.org/attachment.cgi?id=70853&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70853&action=review

> WebKit2/UIProcess/API/qt/qwkhistory.cpp:31
> +QWKHistory::QWKHistory(WebBackForwardList* list)

Doesn't look right from an ABI perspective... add a constructor to the private
QWKHistoryPrivate::create(WebBackForwardList* list) or so

> WebKit2/UIProcess/API/qt/qwkhistory.cpp:32
> +: m_backForwardList(list)

needs indentaton

> WebKit2/UIProcess/API/qt/qwkhistory.cpp:52
> +    return backListCount()+forwardListCount();

needs spaces around +