[webkit-reviews] review granted: [Bug 46802] Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function. : [Attachment 70855] [patch] next iteration.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 46802: Web Inspector: extract consoleMessages related stuff from
populateScriptObjects into separate function.
https://bugs.webkit.org/show_bug.cgi?id=46802

Attachment 70855: [patch] next iteration.
https://bugs.webkit.org/attachment.cgi?id=70855&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70855&action=review

> WebCore/inspector/InspectorController.cpp:625
> +    unsigned messageCount = m_consoleMessages.size();

unsigned -> size_t

> WebCore/inspector/InspectorState.cpp:54
> +    registerBoolean(consoleMessagesNotificationsEnabled, false,
"consoleMessagesNotifications", (const char*)0);

There should be a single place where constants like
"consoleMessagesNotifications" are declared.