[webkit-reviews] review denied: [Bug 42248] [Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine) : [Attachment 70421] Fix GraphicsContextQt::drawLine with X11 paint engine (fifth edition, wuth moved #if)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 15 05:24:05 PDT 2010


Benjamin Poulain <benjamin.poulain at nokia.com> has denied  review:
Bug 42248: [Qt] Hovering the mouse over links produce a trail of underlined
links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248

Attachment 70421: Fix GraphicsContextQt::drawLine with X11 paint engine (fifth
edition, wuth moved #if)
https://bugs.webkit.org/attachment.cgi?id=70421&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70421&action=review

Some nitpicking. Do not forget got put the flags to "?" when you add a patch,
otherwise we don't see it is needing a review.

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:57
> +#include <QtCore>

Please include qglobal instead. Including QtCore means including all the
headers.

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:845
> +#if defined(Q_WS_X11) && defined(Q_OS_UNIX)

Please remove the "&& defined(Q_OS_UNIX)". Some people are using X11 on Windows
as well (I know, it is a strange use case :)).


More information about the webkit-reviews mailing list