[webkit-reviews] review granted: [Bug 47714] Replace some String::format() usages by StringConcatenate in WebKit : [Attachment 70854] Patch v5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 15 05:21:20 PDT 2010
Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 47714: Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
Attachment 70854: Patch v5
https://bugs.webkit.org/attachment.cgi?id=70854&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70854&action=review
LGTM. r=me
> WebKit/chromium/src/BackForwardListClientImpl.cpp:107
> + m_pendingHistoryItem = HistoryItem::create(urlString, String(), 0.0);
Please use 0
More information about the webkit-reviews
mailing list