[webkit-reviews] review denied: [Bug 46723] webkit_web_navigation_action_get_button() wrong : [Attachment 70849] Patch to correct documentation for webkit_web_navigation_action_get_button()

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied  review:
Bug 46723: webkit_web_navigation_action_get_button() wrong
https://bugs.webkit.org/show_bug.cgi?id=46723

Attachment 70849: Patch to correct documentation for
webkit_web_navigation_action_get_button()
https://bugs.webkit.org/attachment.cgi?id=70849&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Some comments:

- The text appears twice in the file, you need to fix it in both places.
- Your fix basically is telling a lie, since those are not the DOM values, but
the GTK+ ones. I think we should either tell the whole story, or just say that
the identifier for the clicked button is returned, leaving it implicit that
it's GTK+'s. I'd vote to do the former.
- You need to generate a ChangeLog and set the patch as r? when submitting it.
Go over this document (http://webkit.org/coding/contributing.html) quickly, but
at the very least I need the ChangeLog to commit your patch :)

Thanks!