[webkit-reviews] review requested: [Bug 41535] "vertical-align: middle; " not working on a MathML element : [Attachment 70843] Revised patch

[bugzilla-daemon at webkit.org]

François Sausset <sausset at gmail.com> has asked	for review:
Bug 41535: "vertical-align: middle;" not working on a MathML element
https://bugs.webkit.org/show_bug.cgi?id=41535

Attachment 70843: Revised patch
https://bugs.webkit.org/attachment.cgi?id=70843&action=review

------- Additional Comments from François Sausset <sausset at gmail.com>
I added comments in the code.

About the int cast, it is a workaround for the "almost" zero value returned by
CGFontGetXHeight().

I changed the guess to use fAscent (float) instead of m_ascent (int) to avoid
the float cast.
The check for fAscent is to avoid an unnecessary computation.

As some tests are modified, it will break the GTK build. Could someone add the
GTK test results? Or rebaseline just after landing?