[webkit-reviews] review denied: [Bug 47698] [EFL] REGRESSION(69798) UCHAR can't be converted to String. : [Attachment 70804] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 47698: [EFL] REGRESSION(69798) UCHAR can't be converted to String.
https://bugs.webkit.org/show_bug.cgi?id=47698

Attachment 70804: Patch
https://bugs.webkit.org/attachment.cgi?id=70804&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70804&action=review

Sorry, I wasn't aware EFL builds is broken. I checked the efl EWS bubble and it
was green. Don't you actually build patches?

> JavaScriptCore/wtf/text/WTFString.h:139
> +    static String character(char);

This should be avoided.

> WebCore/platform/efl/PlatformKeyboardEventEfl.cpp:134
>      String alphabet = "abcdefghijklmnopqrstuvwxyz";

I suggest changing this to:
char alphabet[] = "abc...";

> WebCore/platform/efl/PlatformKeyboardEventEfl.cpp:136
> +	   String key = String::character(static_cast<char>(alphabet[i]));

Then use:
String key(alphabet + i, 1); here.