[webkit-reviews] review denied: [Bug 47706] Add "in select" insertion mode to parser. : [Attachment 70815] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 47706: Add "in select" insertion mode to parser.
https://bugs.webkit.org/show_bug.cgi?id=47706

Attachment 70815: Patch
https://bugs.webkit.org/attachment.cgi?id=70815&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
>From the ASSERT, it looks like you'll need to parse a fragment.  Maybe try
setting the innerHTML of an <option> element to "</select>" ?

<select>
 <option>xxx</option>
</select>

You might need to mix in some optgroup elements or something to see the
difference between table scope and select scope.

r- for no test.  Tests for these sorts of changes are essential.