[webkit-reviews] review requested: [Bug 47572] [Chromium] Leak in WebCore::createFontCustomPlatformData : [Attachment 70835] A quick fix 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 14 23:09:54 PDT 2010
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 47572: [Chromium] Leak in WebCore::createFontCustomPlatformData
https://bugs.webkit.org/show_bug.cgi?id=47572
Attachment 70835: A quick fix 2
https://bugs.webkit.org/attachment.cgi?id=70835&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
(In reply to comment #2)
> (From update of attachment 70584 [details])
> I would prefer to have Chrome call WebCache::clear() when in valgrind mode.
> I don't think the release product should need to clear the WebCore cache
> at renderer shutdown time. It is costly to walk the cache and bring all of
> those objects into memory just to free them. This will make it slower to
> close tabs, etc.
Thank you for your comment. I have added a flag that controls whether we should
clean the resources so we can clean them only when we run Chrome or TestShell
on valgrind. (I'm going to send a Chromium change that actually sets this flag
when running on valgrind.) Is it possible to look the updated one?
Regards,
Hironori Bono
More information about the webkit-reviews
mailing list