[webkit-reviews] review granted: [Bug 47608] Add !SINGLE_THREADED guard. : [Attachment 70811] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 22:00:08 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Hyung Song
<beergun at company100.net>'s request for review:
Bug 47608: Add !SINGLE_THREADED guard.
https://bugs.webkit.org/show_bug.cgi?id=47608

Attachment 70811: patch
https://bugs.webkit.org/attachment.cgi?id=70811&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 For SINGLE_THREADED ports LockingMutex.tryLock() returns false.
+	 This will make interrupt() fall into infinite loop.

A slightly better way to say this would be "This was making interrupt() fall
into infinite loop". The current text sounds like your patch introduces falling
into infinite loop. But it's OK.


More information about the webkit-reviews mailing list