[webkit-reviews] review granted: [Bug 47646] Add guideline for constructors doing implicit type conversion to coding style. : [Attachment 70722] Proposed fix.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 14 16:31:32 PDT 2010
Darin Adler <darin at apple.com> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 47646: Add guideline for constructors doing implicit type conversion to
coding style.
https://bugs.webkit.org/show_bug.cgi?id=47646
Attachment 70722: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=70722&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
Might be worthwhile to mention that we also do not put in the meaningless
explicit keyword when there are no arguments or more than one non-default
argument. I see incorrect uses of explicit in files such as BindingSecurity.h,
JSDOMWrapper.h, JSMainThreadExecState.h, ScheduledAction.h, V8BindingState.h,
Canvas2DLayerChromium.h, RenderThemeQt.h, IDBCursor.h.
More information about the webkit-reviews
mailing list