[webkit-reviews] review granted: [Bug 47677] WebKit2 can load the same plugin multiple times : [Attachment 70763] Make sure WebKit2 only loads each plugin once

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 12:08:26 PDT 2010


Sam Weinig <sam at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 47677: WebKit2 can load the same plugin multiple times
https://bugs.webkit.org/show_bug.cgi?id=47677

Attachment 70763: Make sure WebKit2 only loads each plugin once
https://bugs.webkit.org/attachment.cgi?id=70763&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70763&action=review

> WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:59
> +template <typename T, typename U, typename V, typename W>
> +static void addFromVector(HashSet<T, U, V>& hashSet, const W& vector)
> +{
> +    for (size_t i = 0; i < vector.size(); ++i)
> +	   hashSet.add(vector[i]);
> +}

Should this be in HashSet.h?


More information about the webkit-reviews mailing list