[webkit-reviews] review denied: [Bug 47607] meta tag parser needs to support ; as separator due to Android having made that popular : [Attachment 70644] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 14 10:25:02 PDT 2010
Alexey Proskuryakov <ap at webkit.org> has denied Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 47607: meta tag parser needs to support ; as separator due to Android
having made that popular
https://bugs.webkit.org/show_bug.cgi?id=47607
Attachment 70644: Patch
https://bugs.webkit.org/attachment.cgi?id=70644&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I'm not saying that I'm necessarily against this change, but it needs a better
explanation. Does this work in IE? In Firefox? Opera Mobile? Are these pages
(which ones?) broken on iPhone? What do relevant specs say?
What does Android version history say about reasons for such deviation from
webkit.org?
I'm also unsure about what the scope of this change is. ChangeLog says "meta
tag parser", but it seems that code changes only affect meta viewport. In the
latter is the case, perhaps the question about IE and Firefox isn't valid, but
other ones still stand.
R- because of all the questions, and the lack of test case or an explanation
why one isn't possible.
More information about the webkit-reviews
mailing list