[webkit-reviews] review denied: [Bug 40641] [Qt] Clicking button input does not give it focus : [Attachment 70651] Updated layout test.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 14 06:23:21 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 40641: [Qt] Clicking button input does not give it focus
https://bugs.webkit.org/show_bug.cgi?id=40641

Attachment 70651: Updated layout test.
https://bugs.webkit.org/attachment.cgi?id=70651&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Patch looks almost perfect to go, but we will need one more round.

Apple guys do not usually skip tests unless their DRT can not run the test.
Instead the run the test and check-in the expected result, even if it contains
"expected failures". r- due to this.

To make it easier for you, I ran your test case on Mac's DRT and got the
failing output. I will attach it to this bug. Please amend it as part of our
patch, put it in
LayoutTests/platform/mac/fast/events/click-focus-control-expected.txt. On
windows we could possibly use the same strategy, but I am not sure if it will
produce the exactly same expected result file. We can maybe keep it skipped for
now.


More information about the webkit-reviews mailing list